style(app, protocol-designer): promote confusing void expression lint rule to error, fix all #15327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to error, fix all occurences Promote the two previously demoted testing library eslint rules back to error and correct all outstanding occurences.
… rule to error, fix all Reenable lint error for confusing typescript void expressions and fix all outstanding occurrences of the error.
b-cooper
commented
Jun 4, 2024
There was a problem hiding this comment.
There appears to be a bug here that would make keep removeWellContents from ever being dispatched correctly. @shlokamin
There was a problem hiding this comment.
cc @jerader for viz. thanks for fixing brian!
shlokamin
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Re-enable lint error for confusing typescript void expressions and fix all outstanding occurrences of
the error.
Risk assessment
medium, many files changed